> -----Original Message----- > From: Oleksandr Tyshchenko <olekst...@gmail.com> > Sent: 15 October 2020 17:44 > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>; Paul Durrant > <p...@xen.org>; Jan Beulich > <jbeul...@suse.com>; Andrew Cooper <andrew.coop...@citrix.com>; Roger Pau > Monné > <roger....@citrix.com>; Wei Liu <w...@xen.org>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson > <i...@xenproject.org>; Julien Grall <jul...@xen.org>; Stefano Stabellini > <sstabell...@kernel.org>; Jun > Nakajima <jun.nakaj...@intel.com>; Kevin Tian <kevin.t...@intel.com>; Julien > Grall > <julien.gr...@arm.com> > Subject: [PATCH V2 11/23] xen/ioreq: Move x86's io_completion/io_req fields > to struct vcpu > > From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > > The IOREQ is a common feature now and these fields will be used > on Arm as is. Move them to common struct vcpu as a part of new > struct vcpu_io. Also move enum hvm_io_completion to xen/sched.h > and remove "hvm" prefixes. > > This patch completely removes layering violation in the common code. > > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > CC: Julien Grall <julien.gr...@arm.com> > > --- > Please note, this is a split/cleanup/hardening of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > *** > I was thinking that it may be better to place these two fields > into struct vcpu directly (without intermediate "io" struct). > I think, this way the code which operates with these fields > would become cleaner. Another possible option would be either > to rename "io" struct (I failed to think of a better name) or > to drop(replace?) duplicating "io" prefixes from these fields.
Just drop the 'io_' prefix from the field names. Paul
