On 20.10.2020 11:14, Paul Durrant wrote: >> From: Xen-devel <xen-devel-boun...@lists.xenproject.org> On Behalf Of >> Oleksandr Tyshchenko >> Sent: 15 October 2020 17:44 >> >> --- a/xen/include/asm-x86/hvm/ioreq.h >> +++ b/xen/include/asm-x86/hvm/ioreq.h >> @@ -181,6 +181,8 @@ static inline bool arch_hvm_ioreq_destroy(struct domain >> *d) >> #define IOREQ_STATUS_UNHANDLED X86EMUL_UNHANDLEABLE >> #define IOREQ_STATUS_RETRY X86EMUL_RETRY >> >> +#define ioreq_complete_mmio handle_mmio >> + > > A #define? Really? Can we not have a static inline?
I guess this would require further shuffling: handle_mmio() is an inline function in hvm/emulate.h, and hvm/ioreq.h has no need to include the former (and imo it also shouldn't have). Jan
