> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 30 September 2020 09:35 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Andrew Cooper' > <andrew.coop...@citrix.com>; 'George Dunlap' > <george.dun...@eu.citrix.com>; 'Ian Jackson' <i...@xenproject.org>; 'Julien > Grall' <jul...@xen.org>; > 'Wei Liu' <w...@xen.org>; 'Stefano Stabellini' <sstabell...@kernel.org> > Subject: Re: [PATCH 10/12] evtchn/fifo: use stable fields when recording > "last queue" information > > On 30.09.2020 09:35, Paul Durrant wrote: > >> From: Xen-devel <xen-devel-boun...@lists.xenproject.org> On Behalf Of Jan > >> Beulich > >> Sent: 28 September 2020 12:02 > >> > >> Both evtchn->priority and evtchn->notify_vcpu_id could, prior to recent > >> locking adjustments, change behind the back of > >> evtchn_fifo_set_pending(). Neither the queue's priority nor the vCPU's > >> vcpu_id fields have similar properties, so they seem better suited for > >> the purpose. In particular they reflect the respective evtchn fields' > >> values at the time they were used to determine queue and vCPU. > >> > >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > > > I think these changes make the code clearer anyway. > > > > Reviewed-by: Paul Durrant <p...@xen.org> > > Thanks. With the change of description in the earlier patch, and with > this one possibly going in ahead of it, I'll massage the description > here somewhat, I guess. >
That's fine. Paul
