On 21.09.2020 13:47, Trammell Hudson wrote: > On Friday, September 18, 2020 11:15 AM, Jan Beulich <jbeul...@suse.com> wrote: >> On 17.09.2020 17:40, Trammell Hudson wrote: >> Instead of forcing the caller to pass in a dot-prefixed name >> and you assuming it's a dot here, how about ... >> ... pe_find_section() looking for '.' followed by <name>? > > v6 adds a special name compare function to do this with a > CHAR16 section name to avoid the extra s2w() you mentioned. > > (btw, even if the EFI constness patches don't go in, just > making PrintStr cast away the const would allow several of > these startup functions to have const CHAR16* arguments since > the only reason they are non-const is to be able to print)
And I'd be happy to approve a patch to this effect, provided it uses an inline function and not a macro to do this wrapping. >> [...] >>> - if ( read_section(loaded_image, ".config", &cfg, NULL) ) >>> - PrintStr(L"Using unified config file\\r\\n"); >> >> Maybe "embedded" instead of "unified"? The config file isn't unified >> after all, it's the Xen binary which is. > > How about "builtin"? That's fine with me as well. Jan
