On Wed, Sep 16, 2020 at 08:37:44AM +0000, Trammell Hudson wrote: > On Wednesday, September 16, 2020 3:32 AM, Roger Pau Monné > <roger....@citrix.com> wrote: > > On Mon, Sep 14, 2020 at 07:50:12AM -0400, Trammell Hudson wrote: > > > - s2w(&name_string); > > > > Don't you need to check that s2w succeed, so that name_string.w is not > > a random pointer from stack garbage? > > Maybe? I don't see anywhere else in the code that s2w() is > ever checked for a NULL return.
I see some callers pass the return of s2w() straight into read_file which will check that's not NULL before proceeding, or else call PrintErrMesg which won't return. > Perhaps a better fix would > be to modify the function to panic if it is unable > to allocate. Just doing what read_file does and use PrintErrMesg seems fine to me. Roger.
