On 14.09.2020 16:25, Trammell Hudson wrote: > By defining IN as const, the EFI handler functions become almost > const-correct and allow most of the rest of the EFI boot code to > use constant strings.
How does this work with combined "IN OUT"? I'm afraid there is a reason why things aren't done the way you suggest. > --- a/xen/include/efi/efidef.h > +++ b/xen/include/efi/efidef.h > @@ -50,7 +50,7 @@ typedef VOID *EFI_EVENT; > // > > #ifndef IN > - #define IN > + #define IN const > #define OUT > #define OPTIONAL > #endif I think the #ifdef here is precisely so you can override the three identifiers without having to touch this (imported) header. We try to keep imported headers as little modified as possible. Jan
