On 08/09/2020 11:36, Jan Beulich wrote: > On 08.09.2020 12:08, Andrew Cooper wrote: >> OSSTest has shown an assertion failure: >> http://logs.test-lab.xenproject.org/osstest/logs/153906/test-xtf-amd64-amd64-1/serial-rimava1.log >> >> These assertions were never appropriate, as they rule out legal (and, as it >> turns out, sensible perf-wise) inputs based on an expectation of how the sole >> caller would behave. > I wouldn't put it this way - not coming here was a requirement in > the old logic, when we expected non-null selectors to remain in > sync with the GDT/LDT. But yes, they needs to be dropped now.
Urgh. That is a can of worms, as this path doesn't preserve the GDT attributes/limits. > >> Fixes: ad0fd291c5 ("x86/pv: Rewrite segment context switching from scratch") > With your S-o-b added > Reviewed-by: Jan Beulich <jbeul...@suse.com> Oops. Thanks, but no - I retract this patch. Will submit a different one shortly. ~Andrew