> On Sep 4, 2020, at 11:56 AM, Bertrand Marquis <bertrand.marq...@arm.com> > wrote: > > > >> On 4 Sep 2020, at 11:52, George Dunlap <george.dun...@citrix.com> wrote: >> >> >> >>> On Sep 4, 2020, at 11:49 AM, Bertrand Marquis <bertrand.marq...@arm.com> >>> wrote: >>> >>>> >>>> I tried to add a comment and that is working well >>>> >>>> Remarks from my side: >>>> - How can i ack/test/reject on this ? >>> >>> answer myself as i found the thumbs up that i have to click :-) >> >> I have a button that says “Approve” — do you not have that? Perhaps you >> don’t have the requisite permissions. >> >> But I think adding “Reviewed-by” in a comment would work just as well. > > When you add a comment at the end you can say “Finish review”, maybe that one > is the “Reviewed-by”. > We might need to check if gitlab is not adding those automatically somehow.
At the moment we’re not going to use the gitlab merge functionality. Fundamentally there has to be one “canonical version”, and at the moment that’s the xen.git on xenbits. Committers will have to do a manual pull & push, adding tags manually (as they do now for the mailing list). -George
