On 18.08.2020 12:30, Paul Durrant wrote: > --- a/xen/include/public/save.h > +++ b/xen/include/public/save.h > @@ -93,7 +93,18 @@ struct domain_shared_info_context { > > DECLARE_DOMAIN_SAVE_TYPE(SHARED_INFO, 2, struct domain_shared_info_context); > > -#define DOMAIN_SAVE_CODE_MAX 2 > +#if defined(__i386__) || defined(__x86_64__) > +struct domain_tsc_info_context { > + uint32_t mode; > + uint32_t incarnation; > + uint64_t elapsed_nsec; > + uint32_t khz; > +};
sizeof() for this struct varies between 32-bit and 64-bit - is this not a problem? (alignof() varies too, but there I think it's indeed not a problem, albeit it could still be taken care of by using uint64_aligned_t, alongside the addition of an explicit padding field). Jan