On 25/08/2020 15:29, Wei Chen wrote:
Hi Julien,
-----Original Message-----
From: Julien Grall <jul...@xen.org>
Sent: 2020年8月25日 19:18
To: Wei Chen <wei.c...@arm.com>; xen-devel@lists.xenproject.org;
sstabell...@kernel.org
Cc: Andre Przywara <andre.przyw...@arm.com>; Bertrand Marquis
<bertrand.marq...@arm.com>; Penny Zheng <penny.zh...@arm.com>; Kaly
Xin <kaly....@arm.com>; nd <n...@arm.com>
Subject: Re: [PATCH v3 2/2] xen/arm: Throw messages for unknown FP/SIMD
implement ID
Hi,
On 25/08/2020 11:08, Wei Chen wrote:
Arm ID_AA64PFR0_EL1 register provides two fields to describe CPU
FP/SIMD implementations. Currently, we exactly know the meaning of
0x0, 0x1 and 0xf of these fields. Xen treats value < 8 as FP/SIMD
features presented. If there is a value 0x2 bumped in the future,
Xen behaviors for value <= 0x1 can also take effect. But what Xen
done for value <= 0x1 may not always cover new value 0x2 required.
We throw these messages to break the silence when Xen detected
unknown FP/SIMD IDs to notice user to check.
Signed-off-by: Wei Chen <wei.c...@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
OOI, is this reviewed-by coming from internal review?
Ahh. No, I remember Bertrand gave me a reviewed-by in v2, so I picked it.
I had left OSS for a while, and forgot something. If I can't pick it directly,
could
you please tell me how can I handle such reviewed-by?
In general reviewed-by implies the code was reviewed carefully. They
should only be carried to a new version if they changes are very trivial.
You can also ask the reviewer if he/she is happy with the changes you
will make so you can carry the tag.
Cheers,
--
Julien Grall
