I have no objections. For the OCaml part in particular I previously said that I believe that it would benefit from either be maintained outside the tree (which requires a clean interface) or moving it to use Dune for its build (triggered by the current make build). Any cleanup that is helping here is welcome.
-- Acked-by: Christian Lindig <christian.lin...@citrix.com>?? ________________________________ From: Juergen Gross <jgr...@suse.com> Sent: 23 August 2020 10:34 To: xen-devel@lists.xenproject.org; xen-de...@dornerworks.com Cc: Juergen Gross; Samuel Thibault; Ian Jackson; Wei Liu; George Dunlap; Nick Rosbrook; Andrew Cooper; Jan Beulich; Julien Grall; Stefano Stabellini; Anthony Perard; Marek Marczykowski-Górecki; Josh Whitehead; Stewart Hildebrand; Christian Lindig; David Scott; Shriram Rajagopalan; Yang Hongyang Subject: [PATCH v3 00/38] tools: move most libraries into tools/libs Move most remaining libraries under tools/libs, including libxenctrl and libxl. This is resulting in a lot of cleanup work regarding building libs and restructuring of the tools directory. After this huge cleanup all dependencies between libraries are defined in a single rather small file tools/libs/uselibs.mk, which is used to create the needed make variables and to control the stubdom build dependencies as well. Another bonus of the rework is the automation of setting the versions of unstable libraries. This removes the need to bump those versions manually for each Xen release. libfsimage is not moved by this series, as IMO there are some open questions: - should it really be unstable? - is the support of adding external fs-support used in practice, i.e. shouldn't the fs-specific sub-libraries be just included into libfsimage instead of being loaded dynamically? The complete series is available via: git://xenbits.xen.org/people/jgross/xen.git libbuild-v3
