On 25.08.20 13:16, Marek Marczykowski-Górecki wrote:
On Sun, Aug 23, 2020 at 11:35:07AM +0200, Juergen Gross wrote:
Today tools/libxc needs to be built after tools/libs as libxenctrl is
depending on some libraries in tools/libs. This in turn blocks moving
other libraries depending on libxenctrl below tools/libs.
So carve out libxenctrl from tools/libxc and move it into
tools/libs/ctrl.
Signed-off-by: Juergen Gross <jgr...@suse.com>
Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> (stubdom parts)
Acked-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> (python
parts)
Some other comments below.
--- a/tools/libxc/Makefile
+++ b/tools/libxc/Makefile
@@ -9,47 +9,10 @@ ifeq ($(CONFIG_LIBXC_MINIOS),y)
override CONFIG_MIGRATE := n
endif
...
+LINK_FILES := xc_private.h xc_core.h xc_core_x86.h xc_core_arm.h xc_bitops.h
+
+$(LINK_FILES):
+ ln -sf $(XEN_ROOT)/tools/libs/ctrl/$(notdir $@) $@
Why symlinks instead of adjusting compiler flags?
I want to control which files are accessible.
But then, if symlinks, why not commit them into git instead of creating at
build time?
That's how it is done in the tree at other places.
Juergen
