Hi Anthony, On 8/11/20 12:55 PM, Anthony PERARD wrote: > On Wed, Jul 22, 2020 at 10:25:17AM +0200, Philippe Mathieu-Daudé wrote: >> Xen accelerator requires specific changes to a machine to be able >> to use it. See for example the 'Xen PC' machine configure its PCI >> bus calling pc_xen_hvm_init_pci(). There is no 'Xen Q35' machine >> declared. This code was probably added while introducing the Q35 >> machine, based on the existing PC machine (see commit df2d8b3ed4 >> "Introduce q35 pc based chipset emulator"). Remove the unreachable >> code to simplify this file. > > This is almost correct, we can't start a xen guest with the q35 machine > due to missing setup. But we wouldn't need to declare a new xen specific > machine as setting "accel=xen" is enough.
I'm not sure you are asking me to reword the patch description, but since you gave your A-b, I suppose this is enough as it. > > Anyway, that patch can be reverted whenever someone takes care of > bringing q35 to xen. > >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Acked-by: Anthony PERARD <anthony.per...@citrix.com> Michael, can this go via your tree? Thanks, Phil.
