On 21.08.2020 17:10, Michael Kurth wrote: > From: Michael Kurth <m...@amazon.com> > > Add "all_symbols" to all /tools/symbols calls so that > xen-syms.map lists all symbols and not only .text section > symbols. This change enhances debugging and livepatch > capabilities.
With ifdef CONFIG_LIVEPATCH all_symbols = --all-symbols ifdef CONFIG_FAST_SYMBOL_LOOKUP all_symbols = --all-symbols --sort-by-name endif else all_symbols = endif I agree this helps the CONFIG_LIVEPATCH case, but I doubt you really want --sort-by-name here, and to also cover debugging (as you say) imo you want --all-symbols, not $(all_symbols) in the places that you change. Further, seeing that the places you change are exactly all the ones using --xensyms, I wonder whether the tool shouldn't imply --all-symbols from --xensyms. Jan
