On Wed, Aug 19, 2020 at 09:33:47AM +0200, Jan Beulich wrote: > On 18.08.2020 15:00, Roger Pau Monné wrote: > > On Fri, Aug 07, 2020 at 01:32:38PM +0200, Jan Beulich wrote: > >> There's no need for xen.efi at all, and there's also no need for EFI > >> support in xen.gz since the shim runs in PVH mode, i.e. without any > >> firmware (and hence by implication also without EFI one). > >> > >> The slightly odd looking use of $(space) is to ensure the new ifneq() > >> evaluates consistently between "build" and "install" invocations of > >> make. > > > > I would likely add a comment to the code itself, as it's not obvious > > without a hint IMO. > > I did indeed consider this, as I agree in principle. The problem is > where to put such a comment - ahead of the entire macro is not a > good place imo, and I can't see any other good place either. As a > result I thought that the use being odd looking will either make > readers think of why it's there by itself, or direct them towards > the commit introducing it.
Ahead of the efi-y assignation would be fine for me, but I guess people would use git blame and find the right commit seeing the kind of strange construction that we use there. Thanks, Roger.
