On 12/08/2020 18:42, Trammell Hudson wrote: > There are parameters in xen/arch/x86/boot/cmdline.c that > are only used early in the boot process, so handlers are > necessary to avoid an "Unknown command line option" in > dmesg. > > This also updates ignore_param() to generate a temporary > variable name so that the macro can be used more than once > per file. > > Signed-off-by: Trammell hudson <hud...@trmm.net>
Good spot. However, the use of __LINE__ creates problems for livepatch builds, as it causes the binary diffing tools to believe these changed, based on a change earlier in the file. Instead of opencoding TEMP_NAME(), can we borrow Linux's __UNIQUE_ID() infrastructure? __COUNTER__ appears to have existed for ages, and exists in all of our supported compilers. If you want, I can sort that out as a prereq patch, and rebase this one on top? ~Andrew
