On 06.08.2020 16:15, Trammell Hudson wrote: > On Thursday, August 6, 2020 2:04 PM, Jan Beulich <jbeul...@suse.com> wrote: >> On 06.08.2020 13:44, Trammell Hudson wrote: >>> On Thursday, August 6, 2020 9:57 AM, Jan Beulich jbeul...@suse.com wrote: >>>> Overall I think it might help if this PE parsing code (if UEFI >>>> doesn't offer a protocol to do it for us) was put into its own >>>> source file. >>> >>> I tried to putting it into a separate file and ran into link issues, >>> seems that it needs to be mentioned in both arch/x86/Makefile and >>> arch/x86/pe/Makefile, so this was a "just make it work" for the PoC. >>> Now that it is working, I'll go back to see if I can figure out the >>> makefile magic. >> >> I was rather thinking of e.g. xen/common/efi/pe.c. > > PE parsing code is in now in common/efi/pe.c, with a symlink in arch/x86/efi/, > and I added an extern in common/efi/efi.h. The Makefiles in both arch/x86 and > arch/x86/efi required updates to link in the extra pe.init.o file.
Patches have already been submitted to hopefully make some or even all of these extra adjustments unnecessary. Jan
