On 20.07.2020 18:20, Julien Grall wrote: > On 15/07/2020 11:40, Jan Beulich wrote: >> A subsequent change will exclude domctl.c from getting built for a >> particular configuration, yet the two functions get used from elsewhere. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> >> --- a/xen/common/bitmap.c >> +++ b/xen/common/bitmap.c >> @@ -9,6 +9,9 @@ >> #include <xen/errno.h> >> #include <xen/bitmap.h> >> #include <xen/bitops.h> >> +#include <xen/cpumask.h> >> +#include <xen/domain.h> > > The inclusion of xen/domain.h in common/bitmap.c seems a bit odd to me. > Would it make sense to move the prototype of > bitmap_to_xenctl_bitmap()/xenctl_bitmap_to_bitmap() to bitmap.h?
Ah yes, no idea why it didn't occur to me to do it this way; like you I didn't really like the domain.h inclusion here. (This was what the Arm side cleanup was needed for, which I guess is a nice side effect, but now no longer strictly needed. You've committed that one already anyway.) Jan
