> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 24 June 2020 16:36 > To: Paul Durrant <p...@xen.org> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; > xen-devel@lists.xenproject.org; Wei Liu <w...@xen.org>; > Roger Pau Monné <roger....@citrix.com> > Subject: Ping: [PATCH] x86/CPUID: fill all fields in > x86_cpuid_policy_fill_native() > > (sorry, re-sending with To and Cc corrected) > > On 22.06.2020 14:39, Andrew Cooper wrote: > > On 22/06/2020 13:09, Jan Beulich wrote: > >> Coverity validly complains that the new call from > >> tools/tests/cpu-policy/test-cpu-policy.c:test_cpuid_current() leaves > >> two fields uninitialized, yet they get then consumed by > >> x86_cpuid_copy_to_buffer(). (All other present callers of the function > >> pass a pointer to a static - and hence initialized - buffer.) > >> > >> Coverity-ID: 1464809 > >> Fixes: c22ced93e167 ("tests/cpu-policy: Confirm that CPUID serialisation > >> is sorted") > >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > >> > >> --- a/xen/lib/x86/cpuid.c > >> +++ b/xen/lib/x86/cpuid.c > >> @@ -176,6 +176,10 @@ void x86_cpuid_policy_fill_native(struct > >> ARRAY_SIZE(p->extd.raw) - 1); ++i ) > >> cpuid_leaf(0x80000000 + i, &p->extd.raw[i]); > >> > >> + /* Don't report leaves from possible lower level hypervisor. */ > > > > ", for now." > > > > This will change in the future. > > > > With this, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > > Paul?
Release-acked-by: Paul Durrant <p...@xen.org> > > Thanks, Jan