> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 15 June 2020 17:17 > To: p...@xen.org; 'Andrew Cooper' <andrew.coop...@citrix.com> > Cc: 'Roger Pau Monne' <roger....@citrix.com>; xen-devel@lists.xenproject.org; > 'Wei Liu' <w...@xen.org> > Subject: Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for > GSIs not requiring an EOI > or unmask > > On 11.06.2020 19:11, Paul Durrant wrote: > >> -----Original Message----- > >> From: Andrew Cooper <andrew.coop...@citrix.com> > >> Sent: 11 June 2020 17:26 > >> To: Roger Pau Monne <roger....@citrix.com>; xen-devel@lists.xenproject.org > >> Cc: p...@xen.org; Jan Beulich <jbeul...@suse.com>; Wei Liu <w...@xen.org> > >> Subject: Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for > >> GSIs not requiring an > EOI > >> or unmask > >> > >> On 10/06/2020 15:29, Roger Pau Monne wrote: > >>> There's no need to setup a timer for GSIs that are edge triggered, > >>> since those don't require any EIO or unmask, and hence couldn't block > >>> other interrupts. > >>> > >>> Note this is only used by PVH dom0, that can setup the passthrough of > >>> edge triggered interrupts from the vIO-APIC. One example of such kind > >>> of interrupt that can be used by a PVH dom0 would be the RTC timer. > >>> > >>> While there introduce an out label to do the unlock and reduce code > >>> duplication. > >>> > >>> Signed-off-by: Roger Pau Monné <roger....@citrix.com> > >> > >> Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > > > > Release-acked-by: Paul Durrant <p...@xen.org> > > Strictly speaking these tags were too little for the patch to go > in - the change to drivers/passthrough/io.c would also have > required Paul's (or my) R-b. I take it that this was sort of > implied by the R-a-b.
FAOD I have added my R-b. Paul > > Jan
