Andrew Cooper writes ("[PATCH for-4.14] tools: fix error path of
xendevicemodel_open()"):
> c/s 6902cb00e03 "tools/libxendevicemodel: extract functions and add a compat
> layer" introduced calls to both xencall_open() and osdep_xendevicemodel_open()
> but failed to fix up the error path.
>
> c/s f68c7c618a3 "libs/devicemodel: free xencall handle in error path in
> _open()" fixed up the xencall_open() aspect of the error path (missing the
> osdep_xendevicemodel_open() aspect), but positioned the xencall_close()
> incorrectly, creating the same pattern proved to be problematic by c/s
> 30a72f02870 "tools: fix error path of xenhypfs_open()".
>
> Reposition xtl_logger_destroy(), and introduce the missing
> osdep_xendevicemodel_close().
Reviewed-by: Ian Jackson <[email protected]>
I notice that the tail of xendevicemodel_open is now identical to
xendevicemodel_close. I think this is expected, and that it would be
better to combine the two sets of code. If they hadn't been separate
then we might have avoided this bug...
Ian.
