On 08.05.2020 17:34, Juergen Gross wrote: > --- /dev/null > +++ b/xen/include/xen/hypfs.h > @@ -0,0 +1,122 @@ > +#ifndef __XEN_HYPFS_H__ > +#define __XEN_HYPFS_H__ > + > +#ifdef CONFIG_HYPFS > +#include <xen/list.h> > +#include <xen/string.h> > +#include <public/hypfs.h> > + > +struct hypfs_entry_leaf; > + > +struct hypfs_entry { > + unsigned short type; > + unsigned short encoding; > + unsigned int size; > + unsigned int max_size;
Btw with these, ... > + const char *name; > + struct list_head list; > + int (*read)(const struct hypfs_entry *entry, > + XEN_GUEST_HANDLE_PARAM(void) uaddr); > + int (*write)(struct hypfs_entry_leaf *leaf, > + XEN_GUEST_HANDLE_PARAM(void) uaddr, unsigned long ulen); ... why unsigned long here (noticed while looking at patch 9)? Jan