Despite the inline attribute at least some clang versions warn about trace_shadow_wrmap_bf() being unused in !HVM builds. Include the helper in the #ifdef region.
Fixes: 8b8d011ad868 ("x86/shadow: the guess_wrmap() hook is needed for HVM only") Reported-by: Andrew Cooper <andrew.coop...@citrix.com> Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1756,6 +1756,7 @@ void sh_destroy_shadow(struct domain *d, } } +#ifdef CONFIG_HVM static inline void trace_shadow_wrmap_bf(mfn_t gmfn) { if ( tb_init_done ) @@ -1767,7 +1768,6 @@ static inline void trace_shadow_wrmap_bf } } -#ifdef CONFIG_HVM /**************************************************************************/ /* Remove all writeable mappings of a guest frame from the shadow tables * Returns non-zero if we need to flush TLBs.