Hi Christian,
On 16/04/2020 14:25, Christian Lindig wrote:
The changes in the OCaml C stubs look good to me. They don't really touch the
interface but are mostly concerned with types on the C side by adding casts,
const, and so on. The extended error handling is an improvement.
Thank you for the review! I will commit the rest of the series.
As an aside, the acked-by was adding as part of the signature.
Not sure whether this is intentional but some e-mail clients are hiding
the signature so the acked-by can be easily missed.
Cheers,
--
Julien Grall
