On Thu, Apr 9, 2020 at 2:48 PM Andrew Cooper <andrew.coop...@citrix.com> wrote: > > A default build fails with: > > mem_sharing.c: In function ‘copy_special_pages’: > mem_sharing.c:1649:9: error: ‘HVM_PARAM_STORE_PFN’ undeclared (first use in > this function) > HVM_PARAM_STORE_PFN, > ^~~~~~~~~~~~~~~~~~~ > > I suspect this is a rebasing issue with respect to c/s 12f0c69f2709 "x86/HVM: > reduce hvm.h include dependencies". > > Fixes: 41548c5472a "mem_sharing: VM forking" > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
So staging definitely compiles for me both with and without CONFIG_MEM_SHARING enabled. By default its off, so this shouldn't even be compiled so I'm curious what's happening in your build. That said, I have no objection to the extra include if it turns out to be actually necessary. Tamas
