Hi Jan,
On 31/03/2020 08:30, Jan Beulich wrote:
On 30.03.2020 21:21, Julien Grall wrote:
From: Julien Grall <jgr...@amazon.com>
The fields set_parameter.params and debug.keys should never be modified
by the hypervisor. So mark them as const.
Signed-off-by: Julien Grall <jgr...@amazon.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>
I am not entirely sure whether we should bump the systcl version for
this change. Any thoughts?
No, it should be left as is - it's about _binary_ compatibility (e.g.
if structure layout changes, or a sub-function gets dropped). The
need to potentially address build issues resulting from changes like
the one here isn't covered by it, but by the __XEN__ / __XEN_TOOLS__
conditional at the top of the header.
Thank you for the examplanation! I will commit the patch.
Cheers,
--
Julien Grall