This patch fixes Coverity issue CID 1459006 (Insecure data handling
(INTEGER_OVERFLOW)).
The problem is that the error paths for libxl__mark_domid_recent() and
libxl__is_domid_recent() check the 'f' field in struct libxl__domid_history
when it may not have been initialized.
Signed-off-by: Paul Durrant <pdurr...@amazon.com>
---
Cc: Ian Jackson <ian.jack...@eu.citrix.com>
Cc: Wei Liu <w...@xen.org>
Cc: Anthony PERARD <anthony.per...@citrix.com>
---
tools/libxl/libxl_domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 8937aeb260..41d08394f3 100644
--- a/tools/libxl/libxl_domain.c
+++ b/tools/libxl/libxl_domain.c
@@ -1390,7 +1390,7 @@ static int libxl__read_recent(libxl__gc *gc,
static int libxl__mark_domid_recent(libxl__gc *gc, uint32_t domid)
{
libxl__flock *lock;
- struct libxl__domid_history ctxt;
+ struct libxl__domid_history ctxt = {};
char *new;
FILE *nf = NULL;
int r, rc;
@@ -1461,7 +1461,7 @@ out:
int libxl__is_domid_recent(libxl__gc *gc, uint32_t domid, bool *recent)
{
- struct libxl__domid_history ctxt;
+ struct libxl__domid_history ctxt = {};
int rc;
rc = libxl__open_domid_history(gc, &ctxt);
--
2.20.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
