On Mon, Feb 24, 2020 at 03:14:56PM -0700, Tamas K Lengyel wrote: > > > > +int mem_sharing_fork_page(struct domain *d, gfn_t gfn, bool unsharing) > > > > +{ > > > > + int rc = -ENOENT; > > > > + shr_handle_t handle; > > > > + struct domain *parent; > > > > > > Can you constify parent, I assume there are no changes made to the > > > parent domain, just the forked one. > > > > Sure. > > Actually, no can't do. The parent could get modified here, since we > could end up making the parent's memory into shared entries. So using > const here is not justified since the parent can and does get > modified.
Oh, that's fine. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel