On 20.02.2020 12:43, Wei Liu wrote:
> On Tue, Feb 18, 2020 at 04:47:49PM +0100, Jan Beulich wrote:
>> As the code comment says, this will allow use of a 2Mb super page
>> mapping at the end of "low" memory.
>>
>> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>>
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -563,6 +563,13 @@ int libxl__domain_device_construct_rdm(l
>> /* Just check if RDM > our memory boundary. */
>> if (rdm_start > rdm_mem_boundary) {
>> /*
>> + * For HAP guests round down to a 2Mb boundary to allow use
>> + * of large page mappings.
>> + */
>> + if (libxl_defbool_val(d_config->c_info.hap)
>> + && rdm_start > 0x200000)
>
> Please use MB(2) here.
Will do, but then what about the ~0x1fffff on the next line? Should
this become ~(MB(2) - 1)?
> With this fixed:
>
> Acked-by: Wei Liu <w...@xen.org>
Thanks.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
