On 11/02/2020 16:31, Roger Pau Monné wrote: > On Tue, Feb 11, 2020 at 03:51:54PM +0000, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c >> index 4fa9c91140..ce76d6d776 100644 >> --- a/xen/arch/x86/domctl.c >> +++ b/xen/arch/x86/domctl.c >> @@ -48,7 +48,7 @@ static int gdbsx_guest_mem_io(domid_t domid, struct >> xen_domctl_gdbsx_memio *iop) >> } >> #endif >> >> -static void domain_cpu_policy_changed(struct domain *d) >> +void domain_cpu_policy_changed(struct domain *d) >> { >> const struct cpuid_policy *p = d->arch.cpuid; >> struct vcpu *v; >> @@ -106,6 +106,13 @@ static void domain_cpu_policy_changed(struct domain *d) >> ecx = 0; >> edx = cpufeat_mask(X86_FEATURE_APIC); >> >> + /* >> + * If the Hypervisor bit is set in the policy, we can also >> + * forward it into real CPUID. >> + */ >> + if ( p->basic.hypervisor ) >> + ecx |= cpufeat_mask(X86_FEATURE_HYPERVISOR); > AFAICT dom0 will also get the hypervisor bit set by default, as that's > part of both the HVM and the PV max policy?
Correct. > > If so: > > Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel