On 2/3/20 4:58 PM, Julien Grall wrote:
> From: Julien Grall <jgr...@amazon.com>
>
> It is not entirely clear why the slot 0 of each p2m should be populated
> with empty page-tables. The commit introducing it 759af8e3800 "[HVM]
> Fix 64-bit HVM domain creation." does not contain meaningful
> explanation except that it was necessary for shadow.
Tim, any ideas here?
> As we don't seem to have a good explanation why this is there, drop the
> code completely.
>
> This was tested by successfully booting a HVM with shadow enabled.
>
> Signed-off-by: Julien Grall <jgr...@amazon.com>
>
> ---
>
> I don't know for sure if this is going to break a setup. I have tried
> HVM guest with hap={0, 1} without any trouble. I am happy to try more
> setup if you have any in mind.
>
> If this break a setup, then please describe the setup and I will send a
> documentation patch instead.
This is a somewhat risky strategy. Other than code clean-up, is there
any advantage to removing this code at the moment?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
