> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 30 January 2020 11:02 > To: Durrant, Paul <pdurr...@amazon.co.uk> > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > <andrew.coop...@citrix.com>; George Dunlap <george.dun...@eu.citrix.com>; > Ian Jackson <ian.jack...@eu.citrix.com>; Julien Grall <jul...@xen.org>; > Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Stefano Stabellini > <sstabell...@kernel.org>; Wei Liu <w...@xen.org>; Volodymyr Babchuk > <volodymyr_babc...@epam.com>; Roger Pau Monné <roger....@citrix.com> > Subject: Re: [PATCH v7 2/3] mm: make pages allocated with MEMF_no_refcount > safe to assign > > (replying from seeing your reply on the list archives, i.e. > threading lost/broken) > > On 30.01.2020 10:40, Paul Durrant wrote: > > This is getting very very complicated now, which makes me think that my > > original approach using a 'normal' page and setting an initial max_pages > in > > domain_create() was a better approach. > > I don't think so, no. I also don't thing auditing all ->{max,tot}_pages > uses can be called "very very complicated". All I can say (again, I > think) is that there was a reason this APIC page thing was done the > way it was done. (It's another thing that this probably wasn't a > _good_ reason.) >
I really want to get rid of shared xenheap pages though, so I will persist. I'll add the domain_tot_pages() helper as you suggest. I also agree that steal_page() ought not to encounter a PGC_extra page so I think I'll just make that an error case. Paul _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel