On 1/6/20 11:55 AM, Alexandru Stefan ISAILA wrote: > On 24.12.2019 12:15, George Dunlap wrote: >> On 12/24/19 10:08 AM, Alexandru Stefan ISAILA wrote: >>> >>> >>> On 24.12.2019 10:01, George Dunlap wrote: >>>> On 12/23/19 2:04 PM, Alexandru Stefan ISAILA wrote: >>>> >>>> Why? >>>> >>> >>> This was a request from Jan. >> >> Yes, I saw the Requested-by. It still needs an explanation. >> > > This is what Jan said in V2: > > "All of this is not EPT-specific. Before adding more infrastructure to > cover for this (here: another function parameter), how about moving > these parts into vendor-independent code?" > > If there is a need for further explanation maybe Jan can help here.
You don't have to make every clean-up patch that reviewers ask for; but if you do post a clean-up patch, it's your responsibility to make sure it's got a suitable description. The audience is not only the reviewer who asked for the patch, but also normal developers 5 years from now (perhaps yourself) who are trying to figure out why the change was made. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
