On 09.12.2019 18:29, Andrew Cooper wrote: > On 09/12/2019 16:19, Jan Beulich wrote: >> On 05.12.2019 23:30, Andrew Cooper wrote: >>> @@ -1080,6 +1068,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) >>> u_domctl) >>> if ( copyback && __copy_to_guest(u_domctl, op, 1) ) >>> ret = -EFAULT; >>> >>> + if ( ret == -ERESTART ) >>> + ret = hypercall_create_continuation(__HYPERVISOR_domctl, >>> + "h", u_domctl); >> You may want to mention in the description the bug you fix here: >> Previously the -EFAULT returning visible in context should have >> canceled any active continuation. > > That would be presuming I'd even spotted it... > > Having looked though the paths once again, I don't think there was a > path which continued and had copyback set, so this is at most a latent > bug.
Ah, good. I actually first meant to check, but then forgot before sending the earlier reply. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
