Check that the processor to be woken up APIC ID is addressable in the
current APIC mode.
Note that in practice systems with APIC IDs > 255 should already have
x2APIC enabled by the firmware, and hence this is mostly a safety
belt.
Signed-off-by: Roger Pau Monné <roger....@citrix.com>
---
Changes since v2:
- Reword error message.
---
xen/arch/x86/smpboot.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index fa691b6ba0..8cbb7173a4 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -1317,6 +1317,13 @@ int __cpu_up(unsigned int cpu)
if ( (apicid = x86_cpu_to_apicid[cpu]) == BAD_APICID )
return -ENODEV;
+ if ( (!x2apic_enabled || !iommu_intremap) && (apicid >> 8) )
+ {
+ printk("Unsupported: APIC ID %#x in xAPIC mode w/o interrupt
remapping",
+ apicid);
+ return -EINVAL;
+ }
+
if ( (ret = do_boot_cpu(apicid, cpu)) != 0 )
return ret;
--
2.24.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
