On 04.12.2019 10:43, Andrew Cooper wrote:
> --- a/xen/arch/x86/hvm/svm/intr.c
> +++ b/xen/arch/x86/hvm/svm/intr.c
> @@ -43,15 +43,13 @@ static void svm_inject_nmi(struct vcpu *v)
> {
> struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
> u32 general1_intercepts = vmcb_get_general1_intercepts(vmcb);
> - eventinj_t event;
>
> - event.bytes = 0;
> - event.fields.v = 1;
> - event.fields.type = X86_EVENTTYPE_NMI;
> - event.fields.vector = 2;
> -
> - ASSERT(vmcb->eventinj.fields.v == 0);
> - vmcb->eventinj = event;
> + ASSERT(!vmcb->eventinj.v);
> + vmcb->eventinj = (intinfo_t){
> + .vector = 2,
Perhaps TRAP_nmi here, seeing that TRAP_* are used elsewhere as well?
In any event
Reviewed-by: Jan Beulich <jbeul...@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
