On 25/11/2019 17:27, Roger Pau Monné wrote: > On Mon, Nov 25, 2019 at 05:07:04PM +0000, Wei Liu wrote: >> On Mon, Nov 25, 2019 at 04:59:31PM +0100, Roger Pau Monné wrote: >> [...] >>> Which I think it's expected, we already knew clang had a lot of >>> duplicate symbols. The only way I know to workaround this ATM is to >>> use `gmake xen clang=y CONFIG_ENFORCE_UNIQUE_SYMBOLS=n`. It's on my >>> pile of stuff to look into, but I'm not sure when I will get to it. >> In that case we should make Gitlab CI use the new configuration option. > IMO the build should work out of the box, so we should disable > CONFIG_ENFORCE_UNIQUE_SYMBOLS automatically if clang is detected.
Kconfig in 4.13 isn't in a position to know this. (It will be in 4.14 with Anthony's refresh committed). Furthermore, the causal chain of LIVEPATCH -> ENFORCE_UNIQUE_SYMBOLS *is* correct, because livepatching really is bust if duplicate symbols exist. The only option (which is kconfig-specific) is to disable LIVEPATCH by default. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
