On Fri, Oct 11, 2019 at 07:04:17PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
> --- a/hw/block/xen-block.c
> +++ b/hw/block/xen-block.c
> @@ -915,15 +903,15 @@ static void xen_block_device_create(XenBackendInstance
> *backend,
> goto fail;
> }
>
> - drive = xen_block_drive_create(vdev, device_type, opts, &local_err);
> + drive = xen_block_drive_create(vdev, device_type, opts, errp);
> if (!drive) {
> - error_propagate_prepend(errp, local_err, "failed to create drive: ");
> + error_prepend(errp, "failed to create drive: ");
> goto fail;
> }
>
> - iothread = xen_block_iothread_create(vdev, &local_err);
> - if (local_err) {
> - error_propagate_prepend(errp, local_err,
> + iothread = xen_block_iothread_create(vdev, errp);
> + if (*errp) {
> + error_prepend(errp,
> "failed to create iothread: ");
These two line could be joined now.
> goto fail;
> }
And there are more indentation issues like that in the patch. It would be
nice to fix, but otherwise the patch looks fine:
Acked-by: Anthony PERARD <anthony.per...@citrix.com>
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
