On 04/11/2019 08:31, Durrant, Paul wrote: >> -----Original Message----- >> From: Igor Druzhinin <igor.druzhi...@citrix.com> >> Sent: 01 November 2019 19:28 >> To: xen-devel@lists.xenproject.org >> Cc: Durrant, Paul <pdurr...@amazon.com>; jbeul...@suse.com; >> jgr...@suse.com >> Subject: [PATCH for-4.13 v2] passthrough: simplify locking and logging >> >> From: Paul Durrant <pdurr...@amazon.com> >> >> Dropping the pcidevs lock between calling device_assigned() and >> assign_device() means that the latter has to do the same check as the >> former for no obvious gain. Also, since long running operations under >> pcidevs lock already drop the lock and return -ERESTART periodically there >> is little point in immediately failing an assignment operation with >> -ERESTART just because the pcidevs lock could not be acquired (for the >> second time, having already blocked on acquiring the lock in >> device_assigned()). >> >> This patch instead acquires the lock once for assignment (or test assign) >> operations directly in iommu_do_pci_domctl() and thus can remove the >> duplicate domain ownership check in assign_device(). Whilst in the >> neighbourhood, the patch also removes some debug logging from >> assign_device() and deassign_device() and replaces it with proper error >> logging, which allows error logging in iommu_do_pci_domctl() to be >> removed. Also, since device_assigned() can tell the difference between a >> guest assigned device and a non-existent one, log the actual error >> condition rather then being ambiguous for the sake a few extra lines of >> code. >> >> Signed-off-by: Paul Durrant <pdurr...@amazon.com> >> --- >> >> This is XSA-302 followup and contains some changes important for >> XenServer. >> Juergen, could this be considered for 4.13 inclusion? >> >> v2: updated Paul's email address
This was work you did at Citrix, yes? > Reviewed-by: Paul Durrant <pdurr...@amazon.com> SoB and R-by? ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
