Most of the guest vectors are using the same pattern. This makes fairly
tedious to alter the pattern and risk introducing mistakes when updating
each path.
A new macro is introduced to generate the guest vectors and now use it
in the one that use the open-code version.
Signed-off-by: Julien Grall <julien.gr...@arm.com>
Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
---
Changes in v3:
- Add Stefano's reviewed-by
Changes in v2:
- Use the new short-hands
---
xen/arch/arm/arm64/entry.S | 84 ++++++++++++++++------------------------------
1 file changed, 28 insertions(+), 56 deletions(-)
diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index fac4655bb9..2867c499da 100644
--- a/xen/arch/arm/arm64/entry.S
+++ b/xen/arch/arm/arm64/entry.S
@@ -175,6 +175,30 @@
.endm
+ /*
+ * Generate a guest vector.
+ *
+ * iflags: Correspond to the list of interrupts to unmask
+ * save_x0_x1: See the description on top of the macro 'entry'
+ */
+ .macro guest_vector compat, iflags, trap, save_x0_x1=1
+ entry hyp=0, compat=\compat, save_x0_x1=\save_x0_x1
+ /*
+ * The vSError will be checked while SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT
+ * is not set. If a vSError took place, the initial exception will be
+ * skipped. Exit ASAP
+ */
+ ALTERNATIVE("bl check_pending_vserror; cbnz x0, 1f",
+ "nop; nop",
+ SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT)
+ msr daifclr, \iflags
+ mov x0, sp
+ bl do_trap_\trap
+1:
+ exit hyp=0, compat=\compat
+ .endm
+
+
/*
* Bad Abort numbers
*-----------------
@@ -347,36 +371,10 @@ guest_sync_slowpath:
* x0/x1 may have been scratch by the fast path above, so avoid
* to save them.
*/
- entry hyp=0, compat=0, save_x0_x1=0
- /*
- * The vSError will be checked while SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT
- * is not set. If a vSError took place, the initial exception will be
- * skipped. Exit ASAP
- */
- ALTERNATIVE("bl check_pending_vserror; cbnz x0, 1f",
- "nop; nop",
- SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT)
- msr daifclr, #IFLAGS__AI_
- mov x0, sp
- bl do_trap_guest_sync
-1:
- exit hyp=0, compat=0
+ guest_vector compat=0, iflags=IFLAGS__AI_, trap=guest_sync,
save_x0_x1=0
guest_irq:
- entry hyp=0, compat=0
- /*
- * The vSError will be checked while SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT
- * is not set. If a vSError took place, the initial exception will be
- * skipped. Exit ASAP
- */
- ALTERNATIVE("bl check_pending_vserror; cbnz x0, 1f",
- "nop; nop",
- SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT)
- msr daifclr, #IFLAGS__A__
- mov x0, sp
- bl do_trap_irq
-1:
- exit hyp=0, compat=0
+ guest_vector compat=0, iflags=IFLAGS__A__, trap=irq
guest_fiq_invalid:
entry hyp=0, compat=0
@@ -390,36 +388,10 @@ guest_error:
exit hyp=0, compat=0
guest_sync_compat:
- entry hyp=0, compat=1
- /*
- * The vSError will be checked while SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT
- * is not set. If a vSError took place, the initial exception will be
- * skipped. Exit ASAP
- */
- ALTERNATIVE("bl check_pending_vserror; cbnz x0, 1f",
- "nop; nop",
- SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT)
- msr daifclr, #IFLAGS__AI_
- mov x0, sp
- bl do_trap_guest_sync
-1:
- exit hyp=0, compat=1
+ guest_vector compat=1, iflags=IFLAGS__AI_, trap=guest_sync
guest_irq_compat:
- entry hyp=0, compat=1
- /*
- * The vSError will be checked while SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT
- * is not set. If a vSError took place, the initial exception will be
- * skipped. Exit ASAP
- */
- ALTERNATIVE("bl check_pending_vserror; cbnz x0, 1f",
- "nop; nop",
- SKIP_SYNCHRONIZE_SERROR_ENTRY_EXIT)
- msr daifclr, #IFLAGS__A__
- mov x0, sp
- bl do_trap_irq
-1:
- exit hyp=0, compat=1
+ guest_vector compat=1, iflags=IFLAGS__A__, trap=irq
guest_fiq_invalid_compat:
entry hyp=0, compat=1
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
