On 28.10.19 15:33, Anthony PERARD wrote:
On Sat, Oct 26, 2019 at 02:21:10AM +0300, Petre Pircalabu wrote:
gcc (GCC) 9.2.0 complains:
xentoollog_stubs.c: In function ‘stub_xtl_ocaml_vmessage’:
xentoollog_stubs.c:93:16: error: initialization discards ‘const’ qualifier from
pointer target type [-Werror=discarded-qualifiers]
93 | value *func = caml_named_value(xtl->vmessage_cb) ;
| ^~~~~~~~~~~~~~~~
Hi Petre,
Thanks for the patch, it looks fine. However it would be nice to add
some more context on why gcc complains. A quick search seems to lead to
https://github.com/ocaml/ocaml/commit/4f03a1467d29cf587df5a191830f1525506ee0e3
"Make caml_named_value return a const value*"
which change the prototype of caml_named_value.
With the commit message changed:
Reviewed-by: Anthony PERARD <anthony.per...@citrix.com>
CC Jürgen, I think it would be nice to have the build fix in the
release.
Cheers.
Signed-off-by: Petre Pircalabu <ppircal...@bitdefender.com>
Release-acked-by: Juergen Gross <jgr...@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
