On 10/23/19 2:59 PM, Juergen Gross wrote:
> Since commit 8d3c326f6756d1 ("xen: let vcpu_create() select processor")
> the initial processor for all pv-shim vcpus will be 0, as no other cpus
> are online when the vcpus are created. Before that commit the vcpus
> would have processors set not being online yet, which worked just by
> chance.
> 
> When the pv-shim vcpu becomes active it will have a hard affinity
> not matching its initial processor assignment leading to failing
> ASSERT()s or other problems depending on the selected scheduler.
> 
> Fix that by doing the affinity setting after onlining the cpu but
> before taking the vcpu up. For vcpu 0 this is still in
> sched_setup_dom0_vcpus(), for the other vcpus setting the affinity
> there can be dropped.

I kinda feel like the issue here was that v->processor wasn't re-set
when the vcpu was brought up; but anyway this works:

Acked-by: George Dunlap <george.dun...@citrix.com>


I think this gives it all the acks it needs?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to