On 12/10/2019 15:36, Marek Marczykowski-Górecki wrote:
> Remove unused (#ifdef-ed out) code. Reviving it in its current shape
> won't fly because:
>  - SetVirtualAddressMap() needs to be mapped with 1:1 mapping, which
>    isn't the case at this time
>  - it uses directmap, which is going away soon
>  - it uses directmap, which is mapped with NX, breaking EfiRuntimeServicesCode

I think the second point is far more important than the first.  After
all, there is no guarantee at this point that the directmap is going to
disappear unilaterally - that is simply one option at the moment.

>
> No functional change.
>
> Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com>

Acked-by: Andrew Cooper <andrew.coop...@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to