On 30/09/2019 19:23, Anthony PERARD wrote: > Before the problematic commit, libxl used to ignore error when > destroying (force == true) a passthrough device. If the DM failed to > detach the pci device within the allowed time, the timed out error > raised skip part of pci_remove_*, but also raise the error up to the > caller of libxl__device_pci_destroy_all, libxl__destroy_domid, and > thus the destruction of the domain fails. > > When a *pci_destroy* function is called (so we have force=true), error > should mostly be ignored. If the DM didn't confirmed that the device > is removed, we will print a warning and keep going if force=true. > The patch reorder the functions so that pci_remove_timeout() calls > pci_remove_detatched() like it's done when DM calls are successful. > > We also clean the QMP states and associated timeouts earlier, as soon > as they are not needed anymore. > > Reported-by: Sander Eikelenboom <li...@eikelenboom.it> > Fixes: fae4880c45fe015e567afa223f78bf17a6d98e1b > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
Hi Anthony, Just tested and it works for me, thanks ! -- Sander _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
