On 20.09.19 16:34, Jan Beulich wrote:
On 14.09.2019 10:52, Juergen Gross wrote:
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -474,12 +474,20 @@ int sched_init_vcpu(struct vcpu *v)
return 0;
}
-static void sched_move_irqs(struct vcpu *v)
+static void vcpu_move_irqs(struct vcpu *v)
{
arch_move_irqs(v);
evtchn_move_pirqs(v);
}
+static void sched_move_irqs(struct sched_unit *unit)
I think the parameter could be constified.
Yes.
@@ -1736,7 +1744,7 @@ static void schedule(void)
stop_timer(&prev->vcpu_list->periodic_timer);
if ( next_slice.migrated )
- sched_move_irqs(next->vcpu_list);
+ vcpu_move_irqs(next->vcpu_list);
Why is this not also sched_move_irqs(), at which point there wouldn't
be a need for a separate vcpu_move_irqs() afaict?
This is the place where a single vcpu is scheduled on a new cpu.
The places where sched_move_irqs() is being used is where a unit has
been forced to other cpu(s).
At the end of the series this is much more clear.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel