On 23.09.2019 11:00, Alexandru Stefan ISAILA wrote:
> Ok, just to make sure this is what is needed and limit the patch
> versions, rep_movs / rep_stos should have a switch like this:
>
> switch ( rc )
> {
> case HVMTRANS_okay:
> return X86EMUL_OKAY;
> case HVMTRANS_need_retry:
> ASSERT_UNREACHABLE();
> /* fall through */
> case HVMTRANS_gfn_paged_out:
> case HVMTRANS_gfn_shared:
> return X86EMUL_RETRY;
> }
>
> Then hvmemul_map_linear_addr() should have:
>
> case HVMTRANS_need_retry:
> ASSERT_UNREACHABLE();
> /* fall through */
> case HVMTRANS_gfn_shared:
> case HVMTRANS_gfn_paged_out:
> err = ERR_PTR(~X86EMUL_RETRY);
>
Right, plus a brief comment on the assertions as to why they're
there (to clarify under what condition it would be fine to drop
them).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
