On 10.09.2019 14:31, Paul Durrant wrote: >> -----Original Message----- >> From: Roger Pau Monne <roger....@citrix.com> >> Sent: 03 September 2019 17:14 >> To: xen-devel@lists.xenproject.org >> Cc: Roger Pau Monne <roger....@citrix.com>; Jan Beulich <jbeul...@suse.com>; >> Andrew Cooper >> <andrew.coop...@citrix.com>; Wei Liu <w...@xen.org>; George Dunlap >> <george.dun...@citrix.com>; Ian >> Jackson <ian.jack...@citrix.com>; Julien Grall <julien.gr...@arm.com>; >> Konrad Rzeszutek Wilk >> <konrad.w...@oracle.com>; Stefano Stabellini <sstabell...@kernel.org>; Tim >> (Xen.org) <t...@xen.org>; >> Paul Durrant <paul.durr...@citrix.com> >> Subject: [PATCH v2 03/11] ioreq: switch selection and forwarding to use >> ioservid_t >> >> hvm_select_ioreq_server and hvm_send_ioreq where both using >> hvm_ioreq_server directly, switch to use ioservid_t in order to select >> and forward ioreqs. >> >> This is a preparatory change, since future patches will use the ioreq >> server id in order to differentiate between internal and external >> ioreq servers. >> >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > > ... with one suggestion. > > [snip] >> diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h >> index d3b554d019..8725cc20d3 100644 >> --- a/xen/include/public/hvm/dm_op.h >> +++ b/xen/include/public/hvm/dm_op.h >> @@ -54,6 +54,7 @@ >> */ >> >> typedef uint16_t ioservid_t; >> +#define XEN_INVALID_IOSERVID 0xffff >> > > Perhaps use (ioservid_t)~0 rather than hardcoding?
And then (suitably parenthesized) applicable parts Acked-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
