On 03/09/2019 17:14, Roger Pau Monne wrote:
> diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
> index 692b710b02..69652e1080 100644
> --- a/xen/arch/x86/hvm/ioreq.c
> +++ b/xen/arch/x86/hvm/ioreq.c
> @@ -1015,6 +1015,12 @@ int hvm_map_io_range_to_ioreq_server(struct domain *d, 
> ioservid_t id,
>      switch ( type )
>      {
>      case XEN_DMOP_IO_RANGE_PORT:
> +        rc = -EINVAL;
> +        /* PCI config space accesses are handled internally. */
> +        if ( start <= 0xcf8 + 8 && 0xcf8 <= end )
> +            goto out;
> +        else
> +            /* fallthrough. */

You need to drop the else, or it may still trigger warnings.

Furthermore, qemu registers cf8-cff so I think you need some fix-ups
there first before throwing errors back here.

Finally, this prohibits registering cf9 which may legitimately not be
terminated in Xen.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to