On 19/08/2019 15:26, Julien Grall wrote: > diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h > index 3623af932f..dc4c6a72a0 100644 > --- a/xen/include/public/vcpu.h > +++ b/xen/include/public/vcpu.h > @@ -182,7 +182,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_set_singleshot_timer_t); > */ > #define VCPUOP_register_vcpu_info 10 /* arg == vcpu_register_vcpu_info_t > */ > struct vcpu_register_vcpu_info { > - uint64_t mfn; /* mfn of page to place vcpu_info */ > + uint64_t mfn; /* gfn of page to place vcpu_info */
I wonder if we can do some __XEN_INTERFACE_VERSION__ magic here to properly change the name to gfn. Leaving it as mfn is going to be an ongoing source of confusion. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel