> -----Original Message-----
> From: Julien Grall <julien.gr...@arm.com>
> Sent: 14 August 2019 11:21
> To: Paul Durrant <paul.durr...@citrix.com>; 'Jan Beulich' <jbeul...@suse.com>
> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
> <andrew.coop...@citrix.com>; Roger Pau Monne
> <roger....@citrix.com>; Volodymyr Babchuk <volodymyr_babc...@epam.com>;
> George Dunlap
> <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Stefano
> Stabellini
> <sstabell...@kernel.org>; Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Tim
> (Xen.org) <t...@xen.org>;
> Wei Liu <w...@xen.org>
> Subject: Re: [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and
> need_iommu_pt_sync() macros
>
> Hi Paul,
>
> On 14/08/2019 11:13, Paul Durrant wrote:
> >>> --- a/xen/include/xen/iommu.h
> >>> +++ b/xen/include/xen/iommu.h
> >>> @@ -268,6 +268,13 @@ struct domain_iommu {
> >>> #define iommu_set_feature(d, f) set_bit(f, dom_iommu(d)->features)
> >>> #define iommu_clear_feature(d, f) clear_bit(f, dom_iommu(d)->features)
> >>>
> >>> +/* Are we using the domain P2M table as its IOMMU pagetable? */
> >>> +#define iommu_use_hap_pt(d) \
> >>> + (hap_enabled(d) && is_iommu_enabled(d) && iommu_hap_pt_share)
> >>
> >> Does this build for Arm, seeing that there's no hap_enabled()
> >> definition there? Or have I missed its addition earlier in this
> >> series?
> >
> > It moved to common code sched.h in an earlier patch.
>
> I went through the series and didn't find where hap_enabled() is defined for
> Arm
> in this series. Do you mind pointing the exact patch?
>
Sorry, I wasn't clear... The change is in my other series, "use stashed domain
create flags", which is a pre-requisite for this series (as called out in the
cover letter). The change is made in patch #2 of that series:
https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg02256.html.
Paul
> Cheers,
>
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
